| From ee33717f2cd5909a3d1b83715a837dec41117312 Mon Sep 17 00:00:00 2001 |
| From: Arnd Bergmann <arnd@arndb.de> |
| Date: Mon, 4 Mar 2019 21:23:58 +0100 |
| Subject: phy: mapphone-mdm6600: add gpiolib dependency |
| |
| [ Upstream commit 208d3423ee463ab257908456f6bbca4024ab63f7 ] |
| |
| gcc points out that when CONFIG_GPIOLIB is disabled, |
| gpiod_get_array_value_cansleep() returns 0 but fails to set its output: |
| |
| drivers/phy/motorola/phy-mapphone-mdm6600.c: In function 'phy_mdm6600_status': |
| drivers/phy/motorola/phy-mapphone-mdm6600.c:220:24: error: 'values[0]' is used uninitialized in this function [-Werror=uninitialized] |
| |
| This could be fixed more generally in gpiolib by returning a failure |
| code, but for this specific case, the easier workaround is to add a |
| gpiolib dependency. |
| |
| Fixes: 5d1ebbda0318 ("phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4") |
| Signed-off-by: Arnd Bergmann <arnd@arndb.de> |
| Acked-by: Tony Lindgren <tony@atomide.com> |
| Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/phy/motorola/Kconfig | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/phy/motorola/Kconfig b/drivers/phy/motorola/Kconfig |
| index 82651524ffb9c..718f8729701df 100644 |
| --- a/drivers/phy/motorola/Kconfig |
| +++ b/drivers/phy/motorola/Kconfig |
| @@ -13,7 +13,7 @@ config PHY_CPCAP_USB |
| |
| config PHY_MAPPHONE_MDM6600 |
| tristate "Motorola Mapphone MDM6600 modem USB PHY driver" |
| - depends on OF && USB_SUPPORT |
| + depends on OF && USB_SUPPORT && GPIOLIB |
| select GENERIC_PHY |
| help |
| Enable this for MDM6600 USB modem to work on Motorola phones |
| -- |
| 2.20.1 |
| |
