| From f3b3141253a175bb5c4ba9bf12c2f4073247a0c4 Mon Sep 17 00:00:00 2001 |
| From: Wen Yang <wen.yang99@zte.com.cn> |
| Date: Fri, 12 Apr 2019 14:02:22 +0800 |
| Subject: pinctrl: samsung: fix leaked of_node references |
| |
| [ Upstream commit 44b9f86cd41db6c522effa5aec251d664a52fbc0 ] |
| |
| The call to of_find_compatible_node returns a node pointer with refcount |
| incremented thus it must be explicitly decremented after the last |
| usage. |
| |
| Detected by coccinelle with the following warnings: |
| ./drivers/pinctrl/samsung/pinctrl-exynos-arm.c:76:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 66, but without a corresponding object release within this function. |
| ./drivers/pinctrl/samsung/pinctrl-exynos-arm.c:82:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 66, but without a corresponding object release within this function. |
| |
| Signed-off-by: Wen Yang <wen.yang99@zte.com.cn> |
| Cc: Linus Walleij <linus.walleij@linaro.org> |
| Cc: Tomasz Figa <tomasz.figa@gmail.com> |
| Cc: Sylwester Nawrocki <s.nawrocki@samsung.com> |
| Cc: Kukjin Kim <kgene@kernel.org> |
| Cc: linux-samsung-soc@vger.kernel.org |
| Cc: linux-gpio@vger.kernel.org |
| Cc: linux-kernel@vger.kernel.org |
| Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> |
| Signed-off-by: Linus Walleij <linus.walleij@linaro.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/pinctrl/samsung/pinctrl-exynos-arm.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/drivers/pinctrl/samsung/pinctrl-exynos-arm.c b/drivers/pinctrl/samsung/pinctrl-exynos-arm.c |
| index 44c6b753f692a..85ddf49a51885 100644 |
| --- a/drivers/pinctrl/samsung/pinctrl-exynos-arm.c |
| +++ b/drivers/pinctrl/samsung/pinctrl-exynos-arm.c |
| @@ -71,6 +71,7 @@ s5pv210_retention_init(struct samsung_pinctrl_drv_data *drvdata, |
| } |
| |
| clk_base = of_iomap(np, 0); |
| + of_node_put(np); |
| if (!clk_base) { |
| pr_err("%s: failed to map clock registers\n", __func__); |
| return ERR_PTR(-EINVAL); |
| -- |
| 2.20.1 |
| |