| From 503db02af0e6816fceb22d7bfdec78bce041b81a Mon Sep 17 00:00:00 2001 |
| From: Wen Yang <wen.yang99@zte.com.cn> |
| Date: Fri, 12 Apr 2019 14:02:23 +0800 |
| Subject: pinctrl: zte: fix leaked of_node references |
| |
| [ Upstream commit 02d15f0d80720545f1f4922a1550ea4aaad4e152 ] |
| |
| The call to of_parse_phandle returns a node pointer with refcount |
| incremented thus it must be explicitly decremented after the last |
| usage. |
| |
| Detected by coccinelle with the following warnings: |
| ./drivers/pinctrl/zte/pinctrl-zx.c:415:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 407, but without a corresponding object release within this function. |
| ./drivers/pinctrl/zte/pinctrl-zx.c:422:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 407, but without a corresponding object release within this function. |
| ./drivers/pinctrl/zte/pinctrl-zx.c:436:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 407, but without a corresponding object release within this function. |
| ./drivers/pinctrl/zte/pinctrl-zx.c:444:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 407, but without a corresponding object release within this function. |
| ./drivers/pinctrl/zte/pinctrl-zx.c:448:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 407, but without a corresponding object release within this function. |
| |
| Signed-off-by: Wen Yang <wen.yang99@zte.com.cn> |
| Cc: Linus Walleij <linus.walleij@linaro.org> |
| Cc: Jun Nie <jun.nie@linaro.org> |
| Cc: Linus Walleij <linus.walleij@linaro.org> |
| Cc: linux-gpio@vger.kernel.org |
| Cc: linux-kernel@vger.kernel.org |
| Acked-by: Shawn Guo <shawnguo@kernel.org> |
| Signed-off-by: Linus Walleij <linus.walleij@linaro.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/pinctrl/zte/pinctrl-zx.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/drivers/pinctrl/zte/pinctrl-zx.c b/drivers/pinctrl/zte/pinctrl-zx.c |
| index caa44dd2880a8..3cb69309912ba 100644 |
| --- a/drivers/pinctrl/zte/pinctrl-zx.c |
| +++ b/drivers/pinctrl/zte/pinctrl-zx.c |
| @@ -411,6 +411,7 @@ int zx_pinctrl_init(struct platform_device *pdev, |
| } |
| |
| zpctl->aux_base = of_iomap(np, 0); |
| + of_node_put(np); |
| if (!zpctl->aux_base) |
| return -ENOMEM; |
| |
| -- |
| 2.20.1 |
| |
