| From d87e822fb7d4ae6dcf6046d61a4aaaa1ef693967 Mon Sep 17 00:00:00 2001 |
| From: Bo YU <tsu.yubo@gmail.com> |
| Date: Tue, 30 Oct 2018 09:21:55 -0400 |
| Subject: powerpc/boot: Fix missing check of lseek() return value |
| |
| [ Upstream commit 5d085ec04a000fefb5182d3b03ee46ca96d8389b ] |
| |
| This is detected by Coverity scan: CID: 1440481 |
| |
| Signed-off-by: Bo YU <tsu.yubo@gmail.com> |
| Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| arch/powerpc/boot/addnote.c | 6 +++++- |
| 1 file changed, 5 insertions(+), 1 deletion(-) |
| |
| diff --git a/arch/powerpc/boot/addnote.c b/arch/powerpc/boot/addnote.c |
| index 9d9f6f334d3cc..3da3e2b1b51bc 100644 |
| --- a/arch/powerpc/boot/addnote.c |
| +++ b/arch/powerpc/boot/addnote.c |
| @@ -223,7 +223,11 @@ main(int ac, char **av) |
| PUT_16(E_PHNUM, np + 2); |
| |
| /* write back */ |
| - lseek(fd, (long) 0, SEEK_SET); |
| + i = lseek(fd, (long) 0, SEEK_SET); |
| + if (i < 0) { |
| + perror("lseek"); |
| + exit(1); |
| + } |
| i = write(fd, buf, n); |
| if (i < 0) { |
| perror("write"); |
| -- |
| 2.20.1 |
| |
