| From 7e3152a5137000f456b16420b905d1f770444383 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 12 Apr 2022 07:07:56 +0200 |
| Subject: nvme-pci: disable namespace identifiers for Qemu controllers |
| |
| From: Christoph Hellwig <hch@lst.de> |
| |
| [ Upstream commit 66dd346b84d79fde20832ed691a54f4881eac20d ] |
| |
| Qemu unconditionally reports a UUID, which depending on the qemu version |
| is either all-null (which is incorrect but harmless) or contains a single |
| bit set for all controllers. In addition it can also optionally report |
| a eui64 which needs to be manually set. Disable namespace identifiers |
| for Qemu controlles entirely even if in some cases they could be set |
| correctly through manual intervention. |
| |
| Reported-by: Luis Chamberlain <mcgrof@kernel.org> |
| Signed-off-by: Christoph Hellwig <hch@lst.de> |
| Reviewed-by: Keith Busch <kbusch@kernel.org> |
| Reviewed-by: Sagi Grimberg <sagi@grimberg.me> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/nvme/host/pci.c | 5 ++++- |
| 1 file changed, 4 insertions(+), 1 deletion(-) |
| |
| diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c |
| index 97afeb898b25..6939b03a16c5 100644 |
| --- a/drivers/nvme/host/pci.c |
| +++ b/drivers/nvme/host/pci.c |
| @@ -3212,7 +3212,10 @@ static const struct pci_device_id nvme_id_table[] = { |
| .driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN, }, |
| { PCI_VDEVICE(INTEL, 0x5845), /* Qemu emulated controller */ |
| .driver_data = NVME_QUIRK_IDENTIFY_CNS | |
| - NVME_QUIRK_DISABLE_WRITE_ZEROES, }, |
| + NVME_QUIRK_DISABLE_WRITE_ZEROES | |
| + NVME_QUIRK_BOGUS_NID, }, |
| + { PCI_VDEVICE(REDHAT, 0x0010), /* Qemu emulated controller */ |
| + .driver_data = NVME_QUIRK_BOGUS_NID, }, |
| { PCI_DEVICE(0x126f, 0x2263), /* Silicon Motion unidentified */ |
| .driver_data = NVME_QUIRK_NO_NS_DESC_LIST, }, |
| { PCI_DEVICE(0x1bb1, 0x0100), /* Seagate Nytro Flash Storage */ |
| -- |
| 2.35.1 |
| |
