| From c1f664d2400e73d5ca0fcd067fa5847d2c789c11 Mon Sep 17 00:00:00 2001 |
| From: Huacai Chen <chenhuacai@loongson.cn> |
| Date: Tue, 9 Feb 2021 15:10:51 +0800 |
| Subject: irqchip/loongson-pch-msi: Use bitmap_zalloc() to allocate bitmap |
| |
| From: Huacai Chen <chenhuacai@loongson.cn> |
| |
| commit c1f664d2400e73d5ca0fcd067fa5847d2c789c11 upstream. |
| |
| Currently we use bitmap_alloc() to allocate msi bitmap which should be |
| initialized with zero. This is obviously wrong but it works because msi |
| can fallback to legacy interrupt mode. So use bitmap_zalloc() instead. |
| |
| Fixes: 632dcc2c75ef6de3272aa ("irqchip: Add Loongson PCH MSI controller") |
| Cc: stable@vger.kernel.org |
| Signed-off-by: Huacai Chen <chenhuacai@loongson.cn> |
| Signed-off-by: Marc Zyngier <maz@kernel.org> |
| Link: https://lore.kernel.org/r/20210209071051.2078435-1-chenhuacai@loongson.cn |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/irqchip/irq-loongson-pch-msi.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/irqchip/irq-loongson-pch-msi.c |
| +++ b/drivers/irqchip/irq-loongson-pch-msi.c |
| @@ -225,7 +225,7 @@ static int pch_msi_init(struct device_no |
| goto err_priv; |
| } |
| |
| - priv->msi_map = bitmap_alloc(priv->num_irqs, GFP_KERNEL); |
| + priv->msi_map = bitmap_zalloc(priv->num_irqs, GFP_KERNEL); |
| if (!priv->msi_map) { |
| ret = -ENOMEM; |
| goto err_priv; |