| From 739b4e7756d3301dd673ca517afca46a5f635562 Mon Sep 17 00:00:00 2001 |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| Date: Fri, 1 Oct 2021 15:33:08 +0300 |
| Subject: drm/msm/dsi: Fix an error code in msm_dsi_modeset_init() |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| commit 739b4e7756d3301dd673ca517afca46a5f635562 upstream. |
| |
| Return an error code if msm_dsi_manager_validate_current_config(). |
| Don't return success. |
| |
| Fixes: 8b03ad30e314 ("drm/msm/dsi: Use one connector for dual DSI mode") |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> |
| Link: https://lore.kernel.org/r/20211001123308.GF2283@kili |
| Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> |
| Signed-off-by: Rob Clark <robdclark@chromium.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/gpu/drm/msm/dsi/dsi.c | 4 +++- |
| 1 file changed, 3 insertions(+), 1 deletion(-) |
| |
| --- a/drivers/gpu/drm/msm/dsi/dsi.c |
| +++ b/drivers/gpu/drm/msm/dsi/dsi.c |
| @@ -208,8 +208,10 @@ int msm_dsi_modeset_init(struct msm_dsi |
| goto fail; |
| } |
| |
| - if (!msm_dsi_manager_validate_current_config(msm_dsi->id)) |
| + if (!msm_dsi_manager_validate_current_config(msm_dsi->id)) { |
| + ret = -EINVAL; |
| goto fail; |
| + } |
| |
| msm_dsi->encoder = encoder; |
| |