| From c8f01ffc83923a91e8087aaa077de13354a7aa59 Mon Sep 17 00:00:00 2001 |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| Date: Fri, 1 Oct 2021 15:34:09 +0300 |
| Subject: drm/msm/dsi: fix off by one in dsi_bus_clk_enable error handling |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| commit c8f01ffc83923a91e8087aaa077de13354a7aa59 upstream. |
| |
| This disables a lock which wasn't enabled and it does not disable |
| the first lock in the array. |
| |
| Fixes: 6e0eb52eba9e ("drm/msm/dsi: Parse bus clocks from a list") |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> |
| Link: https://lore.kernel.org/r/20211001123409.GG2283@kili |
| Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> |
| Signed-off-by: Rob Clark <robdclark@chromium.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/gpu/drm/msm/dsi/dsi_host.c |
| +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c |
| @@ -464,7 +464,7 @@ static int dsi_bus_clk_enable(struct msm |
| |
| return 0; |
| err: |
| - for (; i > 0; i--) |
| + while (--i >= 0) |
| clk_disable_unprepare(msm_host->bus_clks[i]); |
| |
| return ret; |
