| From 89a86da5cb8e0ee153111fb68a719d31582c206b Mon Sep 17 00:00:00 2001 |
| From: Alexandru Tachici <alexandru.tachici@analog.com> |
| Date: Mon, 6 Sep 2021 09:56:28 +0300 |
| Subject: iio: adc: ad7192: Add IRQ flag |
| |
| From: Alexandru Tachici <alexandru.tachici@analog.com> |
| |
| commit 89a86da5cb8e0ee153111fb68a719d31582c206b upstream. |
| |
| IRQ type in ad_sigma_delta_info struct was missing. |
| |
| In Sigma-Delta devices the SDO line is also used as an interrupt. |
| Leaving IRQ on level instead of falling might trigger a sample read |
| when the IRQ is enabled, as the SDO line is already low. Not sure |
| if SDO line will always immediately go high in ad_sd_buffer_postenable |
| before the IRQ is enabled. |
| |
| Also the datasheet seem to explicitly say the falling edge of the SDO |
| should be used as an interrupt: |
| >From the AD7192 datasheet: "The DOUT/RDY falling edge can be used |
| as an interrupt to a processor," |
| |
| Fixes: da4d3d6bb9f6 ("iio: adc: ad-sigma-delta: Allow custom IRQ flags") |
| Signed-off-by: Alexandru Tachici <alexandru.tachici@analog.com> |
| Cc: <Stable@vger.kernel.org> |
| Link: https://lore.kernel.org/r/20210906065630.16325-2-alexandru.tachici@analog.com |
| Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/iio/adc/ad7192.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| --- a/drivers/iio/adc/ad7192.c |
| +++ b/drivers/iio/adc/ad7192.c |
| @@ -293,6 +293,7 @@ static const struct ad_sigma_delta_info |
| .has_registers = true, |
| .addr_shift = 3, |
| .read_mask = BIT(6), |
| + .irq_flags = IRQF_TRIGGER_FALLING, |
| }; |
| |
| static const struct ad_sd_calib_data ad7192_calib_arr[8] = { |
