| From bbcf40816b547b3c37af49168950491d20d81ce1 Mon Sep 17 00:00:00 2001 |
| From: Christophe JAILLET <christophe.jaillet@wanadoo.fr> |
| Date: Sat, 21 Aug 2021 12:37:24 +0200 |
| Subject: iio: adc128s052: Fix the error handling path of 'adc128_probe()' |
| |
| From: Christophe JAILLET <christophe.jaillet@wanadoo.fr> |
| |
| commit bbcf40816b547b3c37af49168950491d20d81ce1 upstream. |
| |
| A successful 'regulator_enable()' call should be balanced by a |
| corresponding 'regulator_disable()' call in the error handling path of the |
| probe, as already done in the remove function. |
| |
| Update the error handling path accordingly. |
| |
| Fixes: 913b86468674 ("iio: adc: Add TI ADC128S052") |
| Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> |
| Reviewed-by: Alexandru Ardelean <ardeleanalex@gmail.com> |
| Link: https://lore.kernel.org/r/85189f1cfcf6f5f7b42d8730966f2a074b07b5f5.1629542160.git.christophe.jaillet@wanadoo.fr |
| Cc: <Stable@vger.kernel.org> |
| Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/iio/adc/ti-adc128s052.c | 6 ++++++ |
| 1 file changed, 6 insertions(+) |
| |
| --- a/drivers/iio/adc/ti-adc128s052.c |
| +++ b/drivers/iio/adc/ti-adc128s052.c |
| @@ -171,7 +171,13 @@ static int adc128_probe(struct spi_devic |
| mutex_init(&adc->lock); |
| |
| ret = iio_device_register(indio_dev); |
| + if (ret) |
| + goto err_disable_regulator; |
| |
| + return 0; |
| + |
| +err_disable_regulator: |
| + regulator_disable(adc->reg); |
| return ret; |
| } |
| |