| From 291c932fc3692e4d211a445ba8aa35663831bac7 Mon Sep 17 00:00:00 2001 |
| From: Ziyang Xuan <william.xuanziyang@huawei.com> |
| Date: Wed, 13 Oct 2021 15:50:32 +0800 |
| Subject: NFC: digital: fix possible memory leak in digital_in_send_sdd_req() |
| |
| From: Ziyang Xuan <william.xuanziyang@huawei.com> |
| |
| commit 291c932fc3692e4d211a445ba8aa35663831bac7 upstream. |
| |
| 'skb' is allocated in digital_in_send_sdd_req(), but not free when |
| digital_in_send_cmd() failed, which will cause memory leak. Fix it |
| by freeing 'skb' if digital_in_send_cmd() return failed. |
| |
| Fixes: 2c66daecc409 ("NFC Digital: Add NFC-A technology support") |
| Signed-off-by: Ziyang Xuan <william.xuanziyang@huawei.com> |
| Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> |
| Signed-off-by: Jakub Kicinski <kuba@kernel.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| net/nfc/digital_technology.c | 8 ++++++-- |
| 1 file changed, 6 insertions(+), 2 deletions(-) |
| |
| --- a/net/nfc/digital_technology.c |
| +++ b/net/nfc/digital_technology.c |
| @@ -465,8 +465,12 @@ static int digital_in_send_sdd_req(struc |
| skb_put_u8(skb, sel_cmd); |
| skb_put_u8(skb, DIGITAL_SDD_REQ_SEL_PAR); |
| |
| - return digital_in_send_cmd(ddev, skb, 30, digital_in_recv_sdd_res, |
| - target); |
| + rc = digital_in_send_cmd(ddev, skb, 30, digital_in_recv_sdd_res, |
| + target); |
| + if (rc) |
| + kfree_skb(skb); |
| + |
| + return rc; |
| } |
| |
| static void digital_in_recv_sens_res(struct nfc_digital_dev *ddev, void *arg, |
