| From db9cc7d6f95e7d89b0ce57e785cfd9d67a7505d8 Mon Sep 17 00:00:00 2001 |
| From: Vadim Pasternak <vadimp@nvidia.com> |
| Date: Mon, 27 Sep 2021 17:22:14 +0300 |
| Subject: platform/mellanox: mlxreg-io: Fix read access of n-bytes size attributes |
| |
| From: Vadim Pasternak <vadimp@nvidia.com> |
| |
| commit db9cc7d6f95e7d89b0ce57e785cfd9d67a7505d8 upstream. |
| |
| Fix shift argument for function rol32(). It should be provided in bits, |
| while was provided in bytes. |
| |
| Fixes: 86148190a7db ("platform/mellanox: mlxreg-io: Add support for complex attributes") |
| Signed-off-by: Vadim Pasternak <vadimp@nvidia.com> |
| Link: https://lore.kernel.org/r/20210927142214.2613929-3-vadimp@nvidia.com |
| Signed-off-by: Hans de Goede <hdegoede@redhat.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/platform/mellanox/mlxreg-io.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/platform/mellanox/mlxreg-io.c |
| +++ b/drivers/platform/mellanox/mlxreg-io.c |
| @@ -98,7 +98,7 @@ mlxreg_io_get_reg(void *regmap, struct m |
| if (ret) |
| goto access_error; |
| |
| - *regval |= rol32(val, regsize * i); |
| + *regval |= rol32(val, regsize * i * 8); |
| } |
| } |
| |
