| From c6256feb0643b5b332f5a0aea723082ca4b44ac3 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 10 Dec 2020 22:25:23 +0100 |
| Subject: ARM: dts: exynos: correct PMIC interrupt trigger level on P4 Note |
| family |
| |
| From: Krzysztof Kozlowski <krzk@kernel.org> |
| |
| [ Upstream commit fbe9c9bb2e929865500a0985735f81c0142accad ] |
| |
| The Maxim PMIC datasheets describe the interrupt line as active low |
| with a requirement of acknowledge from the CPU. Without specifying the |
| interrupt type in Devicetree, kernel might apply some fixed |
| configuration, not necessarily working for this hardware. |
| |
| Additionally, the interrupt line is shared so using level sensitive |
| interrupt is here especially important to avoid races. |
| |
| Fixes: f48b5050c301 ("ARM: dts: exynos: add Samsung's Exynos4412-based P4 Note boards") |
| Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> |
| Link: https://lore.kernel.org/r/20201210212534.216197-7-krzk@kernel.org |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| arch/arm/boot/dts/exynos4412-p4note.dtsi | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/arch/arm/boot/dts/exynos4412-p4note.dtsi b/arch/arm/boot/dts/exynos4412-p4note.dtsi |
| index 5fe371543cbb..9e750890edb8 100644 |
| --- a/arch/arm/boot/dts/exynos4412-p4note.dtsi |
| +++ b/arch/arm/boot/dts/exynos4412-p4note.dtsi |
| @@ -322,7 +322,7 @@ |
| max77686: pmic@9 { |
| compatible = "maxim,max77686"; |
| interrupt-parent = <&gpx0>; |
| - interrupts = <7 IRQ_TYPE_NONE>; |
| + interrupts = <7 IRQ_TYPE_LEVEL_LOW>; |
| pinctrl-0 = <&max77686_irq>; |
| pinctrl-names = "default"; |
| reg = <0x09>; |
| -- |
| 2.30.2 |
| |
