| From 777dd3dea1b875832b27b4246ac849f34b8e8f2f Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 1 Apr 2021 16:28:39 +0100 |
| Subject: crypto: sa2ul - Fix memory leak of rxd |
| |
| From: Colin Ian King <colin.king@canonical.com> |
| |
| [ Upstream commit 854b7737199848a91f6adfa0a03cf6f0c46c86e8 ] |
| |
| There are two error return paths that are not freeing rxd and causing |
| memory leaks. Fix these. |
| |
| Addresses-Coverity: ("Resource leak") |
| Fixes: 00c9211f60db ("crypto: sa2ul - Fix DMA mapping API usage") |
| Signed-off-by: Colin Ian King <colin.king@canonical.com> |
| Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/crypto/sa2ul.c | 8 ++++++-- |
| 1 file changed, 6 insertions(+), 2 deletions(-) |
| |
| diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c |
| index d7b1628fb484..b0f0502a5bb0 100644 |
| --- a/drivers/crypto/sa2ul.c |
| +++ b/drivers/crypto/sa2ul.c |
| @@ -1146,8 +1146,10 @@ static int sa_run(struct sa_req *req) |
| mapped_sg->sgt.sgl = src; |
| mapped_sg->sgt.orig_nents = src_nents; |
| ret = dma_map_sgtable(ddev, &mapped_sg->sgt, dir_src, 0); |
| - if (ret) |
| + if (ret) { |
| + kfree(rxd); |
| return ret; |
| + } |
| |
| mapped_sg->dir = dir_src; |
| mapped_sg->mapped = true; |
| @@ -1155,8 +1157,10 @@ static int sa_run(struct sa_req *req) |
| mapped_sg->sgt.sgl = req->src; |
| mapped_sg->sgt.orig_nents = sg_nents; |
| ret = dma_map_sgtable(ddev, &mapped_sg->sgt, dir_src, 0); |
| - if (ret) |
| + if (ret) { |
| + kfree(rxd); |
| return ret; |
| + } |
| |
| mapped_sg->dir = dir_src; |
| mapped_sg->mapped = true; |
| -- |
| 2.30.2 |
| |
