| From a08cb565aeac96a2efa01178916ee17b1cb0353a Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 14 Apr 2021 08:59:22 +0300 |
| Subject: drm/amd/pm: fix error code in smu_set_power_limit() |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| [ Upstream commit bbdfe5aaef3c1d5c5e62fa235ef13f064e4c1c17 ] |
| |
| We should return -EINVAL instead of success if the "limit" is too high. |
| |
| Fixes: e098bc9612c2 ("drm/amd/pm: optimize the power related source code layout") |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Signed-off-by: Alex Deucher <alexander.deucher@amd.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c |
| index e84c737e3967..57b5a9e96893 100644 |
| --- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c |
| +++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c |
| @@ -1931,6 +1931,7 @@ int smu_set_power_limit(struct smu_context *smu, uint32_t limit) |
| dev_err(smu->adev->dev, |
| "New power limit (%d) is over the max allowed %d\n", |
| limit, smu->max_power_limit); |
| + ret = -EINVAL; |
| goto out; |
| } |
| |
| -- |
| 2.30.2 |
| |
