| From f06920dc245c0329a80a1bb6eb5349698adae94e Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 1 Dec 2020 17:31:40 +0800 |
| Subject: i2c: imx-lpi2c: fix reference leak when pm_runtime_get_sync fails |
| |
| From: Qinglang Miao <miaoqinglang@huawei.com> |
| |
| [ Upstream commit 278e5bbdb9a94fa063c0f9bcde2479d0b8042462 ] |
| |
| The PM reference count is not expected to be incremented on |
| return in lpi2c_imx_master_enable. |
| |
| However, pm_runtime_get_sync will increment the PM reference |
| count even failed. Forgetting to putting operation will result |
| in a reference leak here. |
| |
| Replace it with pm_runtime_resume_and_get to keep usage |
| counter balanced. |
| |
| Fixes: 13d6eb20fc79 ("i2c: imx-lpi2c: add runtime pm support") |
| Reported-by: Hulk Robot <hulkci@huawei.com> |
| Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com> |
| Signed-off-by: Wolfram Sang <wsa@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/i2c/busses/i2c-imx-lpi2c.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/drivers/i2c/busses/i2c-imx-lpi2c.c |
| index 9db6ccded5e9..8b9ba055c418 100644 |
| --- a/drivers/i2c/busses/i2c-imx-lpi2c.c |
| +++ b/drivers/i2c/busses/i2c-imx-lpi2c.c |
| @@ -259,7 +259,7 @@ static int lpi2c_imx_master_enable(struct lpi2c_imx_struct *lpi2c_imx) |
| unsigned int temp; |
| int ret; |
| |
| - ret = pm_runtime_get_sync(lpi2c_imx->adapter.dev.parent); |
| + ret = pm_runtime_resume_and_get(lpi2c_imx->adapter.dev.parent); |
| if (ret < 0) |
| return ret; |
| |
| -- |
| 2.30.2 |
| |
