| From 4fdf3b6f7447e1ce671d7c07032adffad1e44db2 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sat, 10 Apr 2021 23:25:10 +0300 |
| Subject: i2c: sh7760: add IRQ check |
| |
| From: Sergey Shtylyov <s.shtylyov@omprussia.ru> |
| |
| [ Upstream commit e5b2e3e742015dd2aa6bc7bcef2cb59b2de1221c ] |
| |
| The driver neglects to check the result of platform_get_irq()'s call and |
| blithely passes the negative error codes to devm_request_irq() (which |
| takes *unsigned* IRQ #), causing it to fail with -EINVAL, overriding |
| an original error code. Stop calling devm_request_irq() with invalid |
| IRQ #s. |
| |
| Fixes: a26c20b1fa6d ("i2c: Renesas SH7760 I2C master driver") |
| Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru> |
| Signed-off-by: Wolfram Sang <wsa@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/i2c/busses/i2c-sh7760.c | 5 ++++- |
| 1 file changed, 4 insertions(+), 1 deletion(-) |
| |
| diff --git a/drivers/i2c/busses/i2c-sh7760.c b/drivers/i2c/busses/i2c-sh7760.c |
| index c2005c789d2b..c79c9f542c5a 100644 |
| --- a/drivers/i2c/busses/i2c-sh7760.c |
| +++ b/drivers/i2c/busses/i2c-sh7760.c |
| @@ -471,7 +471,10 @@ static int sh7760_i2c_probe(struct platform_device *pdev) |
| goto out2; |
| } |
| |
| - id->irq = platform_get_irq(pdev, 0); |
| + ret = platform_get_irq(pdev, 0); |
| + if (ret < 0) |
| + return ret; |
| + id->irq = ret; |
| |
| id->adap.nr = pdev->id; |
| id->adap.algo = &sh7760_i2c_algo; |
| -- |
| 2.30.2 |
| |
