| From 608a64fb00b7ccd3df1bcec81c94c99b886dc43a Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 31 Mar 2021 16:36:02 +0800 |
| Subject: net/tipc: fix missing destroy_workqueue() on error in |
| tipc_crypto_start() |
| |
| From: Yang Yingliang <yangyingliang@huawei.com> |
| |
| [ Upstream commit ac1db7acea67777be1ba86e36e058c479eab6508 ] |
| |
| Add the missing destroy_workqueue() before return from |
| tipc_crypto_start() in the error handling case. |
| |
| Fixes: 1ef6f7c9390f ("tipc: add automatic session key exchange") |
| Reported-by: Hulk Robot <hulkci@huawei.com> |
| Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| net/tipc/crypto.c | 2 ++ |
| 1 file changed, 2 insertions(+) |
| |
| diff --git a/net/tipc/crypto.c b/net/tipc/crypto.c |
| index 97710ce36047..c89ce47c56cf 100644 |
| --- a/net/tipc/crypto.c |
| +++ b/net/tipc/crypto.c |
| @@ -1492,6 +1492,8 @@ int tipc_crypto_start(struct tipc_crypto **crypto, struct net *net, |
| /* Allocate statistic structure */ |
| c->stats = alloc_percpu_gfp(struct tipc_crypto_stats, GFP_ATOMIC); |
| if (!c->stats) { |
| + if (c->wq) |
| + destroy_workqueue(c->wq); |
| kfree_sensitive(c); |
| return -ENOMEM; |
| } |
| -- |
| 2.30.2 |
| |
