| From 88cc92eb67764b47f45ace9a4fa62eea0cfc52a1 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 8 Apr 2021 11:31:32 +0000 |
| Subject: RDMA/srpt: Fix error return code in srpt_cm_req_recv() |
| |
| From: Wang Wensheng <wangwensheng4@huawei.com> |
| |
| [ Upstream commit 6bc950beff0c440ac567cdc4e7f4542a9920953d ] |
| |
| Fix to return a negative error code from the error handling case instead |
| of 0, as done elsewhere in this function. |
| |
| Fixes: db7683d7deb2 ("IB/srpt: Fix login-related race conditions") |
| Link: https://lore.kernel.org/r/20210408113132.87250-1-wangwensheng4@huawei.com |
| Reported-by: Hulk Robot <hulkci@huawei.com> |
| Signed-off-by: Wang Wensheng <wangwensheng4@huawei.com> |
| Reviewed-by: Bart Van Assche <bvanassche@acm.org> |
| Signed-off-by: Jason Gunthorpe <jgg@nvidia.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/infiniband/ulp/srpt/ib_srpt.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c |
| index 6be60aa5ffe2..7f0420ad9057 100644 |
| --- a/drivers/infiniband/ulp/srpt/ib_srpt.c |
| +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c |
| @@ -2378,6 +2378,7 @@ static int srpt_cm_req_recv(struct srpt_device *const sdev, |
| pr_info("rejected SRP_LOGIN_REQ because target %s_%d is not enabled\n", |
| dev_name(&sdev->device->dev), port_num); |
| mutex_unlock(&sport->mutex); |
| + ret = -EINVAL; |
| goto reject; |
| } |
| |
| -- |
| 2.30.2 |
| |
