| From af6fbb8e65c2dd715ff6cbb73730033f9de787ef Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sun, 28 Mar 2021 00:13:49 +0300 |
| Subject: sata_mv: add IRQ checks |
| |
| From: Sergey Shtylyov <s.shtylyov@omprussia.ru> |
| |
| [ Upstream commit e6471a65fdd5efbb8dd2732dd0f063f960685ceb ] |
| |
| The function mv_platform_probe() neglects to check the results of the |
| calls to platform_get_irq() and irq_of_parse_and_map() and blithely |
| passes them to ata_host_activate() -- while the latter only checks |
| for IRQ0 (treating it as a polling mode indicattion) and passes the |
| negative values to devm_request_irq() causing it to fail as it takes |
| unsigned values for the IRQ #... |
| |
| Add to mv_platform_probe() the proper IRQ checks to pass the positive IRQ |
| #s to ata_host_activate(), propagate upstream the negative error codes, |
| and override the IRQ0 with -EINVAL (as we don't want the polling mode). |
| |
| Fixes: f351b2d638c3 ("sata_mv: Support SoC controllers") |
| Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru> |
| Link: https://lore.kernel.org/r/51436f00-27a1-e20b-c21b-0e817e0a7c86@omprussia.ru |
| Signed-off-by: Jens Axboe <axboe@kernel.dk> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/ata/sata_mv.c | 4 ++++ |
| 1 file changed, 4 insertions(+) |
| |
| diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c |
| index 664ef658a955..b62446ea5f40 100644 |
| --- a/drivers/ata/sata_mv.c |
| +++ b/drivers/ata/sata_mv.c |
| @@ -4097,6 +4097,10 @@ static int mv_platform_probe(struct platform_device *pdev) |
| n_ports = mv_platform_data->n_ports; |
| irq = platform_get_irq(pdev, 0); |
| } |
| + if (irq < 0) |
| + return irq; |
| + if (!irq) |
| + return -EINVAL; |
| |
| host = ata_host_alloc_pinfo(&pdev->dev, ppi, n_ports); |
| hpriv = devm_kzalloc(&pdev->dev, sizeof(*hpriv), GFP_KERNEL); |
| -- |
| 2.30.2 |
| |
