| From 427fbe7a9e33ca628a92fc9c2144a8ef68b61a75 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 23 Apr 2021 14:19:43 +0200 |
| Subject: selftests: net: mirror_gre_vlan_bridge_1q: Make an FDB entry static |
| |
| From: Petr Machata <petrm@nvidia.com> |
| |
| [ Upstream commit c8d0260cdd96fdccdef0509c4160e28a1012a5d7 ] |
| |
| The FDB roaming test installs a destination MAC address on the wrong |
| interface of an FDB database and tests whether the mirroring fails, because |
| packets are sent to the wrong port. The test by mistake installs the FDB |
| entry as local. This worked previously, because drivers were notified of |
| local FDB entries in the same way as of static entries. However that has |
| been fixed in the commit 6ab4c3117aec ("net: bridge: don't notify switchdev |
| for local FDB addresses"), and local entries are not notified anymore. As a |
| result, the HW is not reconfigured for the FDB roam, and mirroring keeps |
| working, failing the test. |
| |
| To fix the issue, mark the FDB entry as static. |
| |
| Fixes: 9c7c8a82442c ("selftests: forwarding: mirror_gre_vlan_bridge_1q: Add more tests") |
| Signed-off-by: Petr Machata <petrm@nvidia.com> |
| Reviewed-by: Ido Schimmel <idosch@nvidia.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| .../selftests/net/forwarding/mirror_gre_vlan_bridge_1q.sh | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/tools/testing/selftests/net/forwarding/mirror_gre_vlan_bridge_1q.sh b/tools/testing/selftests/net/forwarding/mirror_gre_vlan_bridge_1q.sh |
| index c02291e9841e..880e3ab9d088 100755 |
| --- a/tools/testing/selftests/net/forwarding/mirror_gre_vlan_bridge_1q.sh |
| +++ b/tools/testing/selftests/net/forwarding/mirror_gre_vlan_bridge_1q.sh |
| @@ -271,7 +271,7 @@ test_span_gre_fdb_roaming() |
| |
| while ((RET == 0)); do |
| bridge fdb del dev $swp3 $h3mac vlan 555 master 2>/dev/null |
| - bridge fdb add dev $swp2 $h3mac vlan 555 master |
| + bridge fdb add dev $swp2 $h3mac vlan 555 master static |
| sleep 1 |
| fail_test_span_gre_dir $tundev ingress |
| |
| -- |
| 2.30.2 |
| |
