| From b8b719524f9fda7a5e3050df80c4e8d0b7072e13 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 30 Mar 2021 21:01:59 +0800 |
| Subject: USB: gadget: udc: fix wrong pointer passed to IS_ERR() and PTR_ERR() |
| |
| From: Yang Yingliang <yangyingliang@huawei.com> |
| |
| [ Upstream commit 2e3d055bf27d70204cae349335a62a4f9b7c165a ] |
| |
| IS_ERR() and PTR_ERR() use wrong pointer, it should be |
| udc->virt_addr, fix it. |
| |
| Fixes: 1b9f35adb0ff ("usb: gadget: udc: Add Synopsys UDC Platform driver") |
| Reported-by: Hulk Robot <hulkci@huawei.com> |
| Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> |
| Link: https://lore.kernel.org/r/20210330130159.1051979-1-yangyingliang@huawei.com |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/usb/gadget/udc/snps_udc_plat.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| diff --git a/drivers/usb/gadget/udc/snps_udc_plat.c b/drivers/usb/gadget/udc/snps_udc_plat.c |
| index 32f1d3e90c26..99805d60a7ab 100644 |
| --- a/drivers/usb/gadget/udc/snps_udc_plat.c |
| +++ b/drivers/usb/gadget/udc/snps_udc_plat.c |
| @@ -114,8 +114,8 @@ static int udc_plat_probe(struct platform_device *pdev) |
| |
| res = platform_get_resource(pdev, IORESOURCE_MEM, 0); |
| udc->virt_addr = devm_ioremap_resource(dev, res); |
| - if (IS_ERR(udc->regs)) |
| - return PTR_ERR(udc->regs); |
| + if (IS_ERR(udc->virt_addr)) |
| + return PTR_ERR(udc->virt_addr); |
| |
| /* udc csr registers base */ |
| udc->csr = udc->virt_addr + UDC_CSR_ADDR; |
| -- |
| 2.30.2 |
| |
