| From 518bc6829e84e3414fe73a4466f299f0e2038e0a Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 8 Apr 2021 19:23:05 +0800 |
| Subject: usbip: vudc: fix missing unlock on error in usbip_sockfd_store() |
| |
| From: Ye Bin <yebin10@huawei.com> |
| |
| [ Upstream commit 1d08ed588c6a85a35a24c82eb4cf0807ec2b366a ] |
| |
| Add the missing unlock before return from function usbip_sockfd_store() |
| in the error handling case. |
| |
| Fixes: bd8b82042269 ("usbip: vudc synchronize sysfs code paths") |
| Reported-by: Hulk Robot <hulkci@huawei.com> |
| Acked-by: Shuah Khan <skhan@linuxfoundation.org> |
| Signed-off-by: Ye Bin <yebin10@huawei.com> |
| Link: https://lore.kernel.org/r/20210408112305.1022247-1-yebin10@huawei.com |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/usb/usbip/vudc_sysfs.c | 2 ++ |
| 1 file changed, 2 insertions(+) |
| |
| diff --git a/drivers/usb/usbip/vudc_sysfs.c b/drivers/usb/usbip/vudc_sysfs.c |
| index f7633ee655a1..d1cf6b51bf85 100644 |
| --- a/drivers/usb/usbip/vudc_sysfs.c |
| +++ b/drivers/usb/usbip/vudc_sysfs.c |
| @@ -156,12 +156,14 @@ static ssize_t usbip_sockfd_store(struct device *dev, |
| tcp_rx = kthread_create(&v_rx_loop, &udc->ud, "vudc_rx"); |
| if (IS_ERR(tcp_rx)) { |
| sockfd_put(socket); |
| + mutex_unlock(&udc->ud.sysfs_lock); |
| return -EINVAL; |
| } |
| tcp_tx = kthread_create(&v_tx_loop, &udc->ud, "vudc_tx"); |
| if (IS_ERR(tcp_tx)) { |
| kthread_stop(tcp_rx); |
| sockfd_put(socket); |
| + mutex_unlock(&udc->ud.sysfs_lock); |
| return -EINVAL; |
| } |
| |
| -- |
| 2.30.2 |
| |
