| From 7674b7b559b683478c3832527c59bceb169e701d Mon Sep 17 00:00:00 2001 |
| From: Raju Rangoju <Raju.Rangoju@amd.com> |
| Date: Thu, 27 Jan 2022 11:32:22 +0530 |
| Subject: net: amd-xgbe: ensure to reset the tx_timer_active flag |
| |
| From: Raju Rangoju <Raju.Rangoju@amd.com> |
| |
| commit 7674b7b559b683478c3832527c59bceb169e701d upstream. |
| |
| Ensure to reset the tx_timer_active flag in xgbe_stop(), |
| otherwise a port restart may result in tx timeout due to |
| uncleared flag. |
| |
| Fixes: c635eaacbf77 ("amd-xgbe: Remove Tx coalescing") |
| Co-developed-by: Sudheesh Mavila <sudheesh.mavila@amd.com> |
| Signed-off-by: Sudheesh Mavila <sudheesh.mavila@amd.com> |
| Signed-off-by: Raju Rangoju <Raju.Rangoju@amd.com> |
| Acked-by: Tom Lendacky <thomas.lendacky@amd.com> |
| Link: https://lore.kernel.org/r/20220127060222.453371-1-Raju.Rangoju@amd.com |
| Signed-off-by: Jakub Kicinski <kuba@kernel.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 2 ++ |
| 1 file changed, 2 insertions(+) |
| |
| --- a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c |
| +++ b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c |
| @@ -721,7 +721,9 @@ static void xgbe_stop_timers(struct xgbe |
| if (!channel->tx_ring) |
| break; |
| |
| + /* Deactivate the Tx timer */ |
| del_timer_sync(&channel->tx_timer); |
| + channel->tx_timer_active = 0; |
| } |
| } |
| |