| From d2c0f45fcceb0995f208c441d9c9a453623f9ccf Mon Sep 17 00:00:00 2001 |
| From: Slawomir Laba <slawomirx.laba@intel.com> |
| Date: Wed, 23 Feb 2022 13:38:43 +0100 |
| Subject: iavf: Fix missing check for running netdev |
| |
| From: Slawomir Laba <slawomirx.laba@intel.com> |
| |
| commit d2c0f45fcceb0995f208c441d9c9a453623f9ccf upstream. |
| |
| The driver was queueing reset_task regardless of the netdev |
| state. |
| |
| Do not queue the reset task in iavf_change_mtu if netdev |
| is not running. |
| |
| Fixes: fdd4044ffdc8 ("iavf: Remove timer for work triggering, use delaying work instead") |
| Signed-off-by: Slawomir Laba <slawomirx.laba@intel.com> |
| Signed-off-by: Phani Burra <phani.r.burra@intel.com> |
| Signed-off-by: Jacob Keller <jacob.e.keller@intel.com> |
| Signed-off-by: Mateusz Palczewski <mateusz.palczewski@intel.com> |
| Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com> |
| Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/net/ethernet/intel/iavf/iavf_main.c | 7 +++++-- |
| 1 file changed, 5 insertions(+), 2 deletions(-) |
| |
| --- a/drivers/net/ethernet/intel/iavf/iavf_main.c |
| +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c |
| @@ -3323,8 +3323,11 @@ static int iavf_change_mtu(struct net_de |
| iavf_notify_client_l2_params(&adapter->vsi); |
| adapter->flags |= IAVF_FLAG_SERVICE_CLIENT_REQUESTED; |
| } |
| - adapter->flags |= IAVF_FLAG_RESET_NEEDED; |
| - queue_work(iavf_wq, &adapter->reset_task); |
| + |
| + if (netif_running(netdev)) { |
| + adapter->flags |= IAVF_FLAG_RESET_NEEDED; |
| + queue_work(iavf_wq, &adapter->reset_task); |
| + } |
| |
| return 0; |
| } |
