| From dc7f4609085aed3da0117362d6ab5a4ab827c681 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 17 Sep 2019 17:47:12 -0500 |
| Subject: ieee802154: ca8210: prevent memory leak |
| |
| From: Navid Emamdoost <navid.emamdoost@gmail.com> |
| |
| [ Upstream commit 6402939ec86eaf226c8b8ae00ed983936b164908 ] |
| |
| In ca8210_probe the allocated pdata needs to be assigned to |
| spi_device->dev.platform_data before calling ca8210_get_platform_data. |
| Othrwise when ca8210_get_platform_data fails pdata cannot be released. |
| |
| Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com> |
| Link: https://lore.kernel.org/r/20190917224713.26371-1-navid.emamdoost@gmail.com |
| Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/ieee802154/ca8210.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c |
| index dcd10dba08c72..3a58962babd41 100644 |
| --- a/drivers/net/ieee802154/ca8210.c |
| +++ b/drivers/net/ieee802154/ca8210.c |
| @@ -3153,12 +3153,12 @@ static int ca8210_probe(struct spi_device *spi_device) |
| goto error; |
| } |
| |
| + priv->spi->dev.platform_data = pdata; |
| ret = ca8210_get_platform_data(priv->spi, pdata); |
| if (ret) { |
| dev_crit(&spi_device->dev, "ca8210_get_platform_data failed\n"); |
| goto error; |
| } |
| - priv->spi->dev.platform_data = pdata; |
| |
| ret = ca8210_dev_com_init(priv); |
| if (ret) { |
| -- |
| 2.20.1 |
| |
