| From b6c03e5f7b463efcafd1ce141bd5a8fc4e583ae2 Mon Sep 17 00:00:00 2001 |
| From: Johan Hovold <johan@kernel.org> |
| Date: Thu, 10 Oct 2019 14:58:35 +0200 |
| Subject: USB: legousbtower: fix memleak on disconnect |
| |
| From: Johan Hovold <johan@kernel.org> |
| |
| commit b6c03e5f7b463efcafd1ce141bd5a8fc4e583ae2 upstream. |
| |
| If disconnect() races with release() after a process has been |
| interrupted, release() could end up returning early and the driver would |
| fail to free its driver data. |
| |
| Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") |
| Cc: stable <stable@vger.kernel.org> |
| Signed-off-by: Johan Hovold <johan@kernel.org> |
| Link: https://lore.kernel.org/r/20191010125835.27031-3-johan@kernel.org |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/usb/misc/legousbtower.c | 5 +---- |
| 1 file changed, 1 insertion(+), 4 deletions(-) |
| |
| --- a/drivers/usb/misc/legousbtower.c |
| +++ b/drivers/usb/misc/legousbtower.c |
| @@ -423,10 +423,7 @@ static int tower_release (struct inode * |
| goto exit; |
| } |
| |
| - if (mutex_lock_interruptible(&dev->lock)) { |
| - retval = -ERESTARTSYS; |
| - goto exit; |
| - } |
| + mutex_lock(&dev->lock); |
| |
| if (dev->open_count != 1) { |
| dev_dbg(&dev->udev->dev, "%s: device not opened exactly once\n", |
