| From b44b35a01c98e3a0b54738cc670974c1c20664d6 Mon Sep 17 00:00:00 2001 |
| From: Chengguang Xu <cgxu519@gmx.com> |
| Date: Wed, 13 Jun 2018 12:05:13 +0800 |
| Subject: fs/exofs: fix potential memory leak in mount option parsing |
| |
| [ Upstream commit 515f1867addaba49c1c6ac73abfaffbc192c1db4 ] |
| |
| There are some cases can cause memory leak when parsing |
| option 'osdname'. |
| |
| Signed-off-by: Chengguang Xu <cgxu519@gmx.com> |
| Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| fs/exofs/super.c | 5 ++++- |
| 1 file changed, 4 insertions(+), 1 deletion(-) |
| |
| diff --git a/fs/exofs/super.c b/fs/exofs/super.c |
| index 41cf2fbee50d..7d61e3fa378c 100644 |
| --- a/fs/exofs/super.c |
| +++ b/fs/exofs/super.c |
| @@ -101,6 +101,7 @@ static int parse_options(char *options, struct exofs_mountopt *opts) |
| token = match_token(p, tokens, args); |
| switch (token) { |
| case Opt_name: |
| + kfree(opts->dev_name); |
| opts->dev_name = match_strdup(&args[0]); |
| if (unlikely(!opts->dev_name)) { |
| EXOFS_ERR("Error allocating dev_name"); |
| @@ -866,8 +867,10 @@ static struct dentry *exofs_mount(struct file_system_type *type, |
| int ret; |
| |
| ret = parse_options(data, &opts); |
| - if (ret) |
| + if (ret) { |
| + kfree(opts.dev_name); |
| return ERR_PTR(ret); |
| + } |
| |
| if (!opts.dev_name) |
| opts.dev_name = dev_name; |
| -- |
| 2.17.1 |
| |
