| From 21f70d4abf9e17c2e3d7e64b7bfa3424e017f176 Mon Sep 17 00:00:00 2001 |
| From: Olof Johansson <olof@lixom.net> |
| Date: Wed, 14 Nov 2018 16:27:55 -0800 |
| Subject: RISC-V: Fix raw_copy_{to,from}_user() |
| |
| From: Olof Johansson <olof@lixom.net> |
| |
| commit 21f70d4abf9e17c2e3d7e64b7bfa3424e017f176 upstream. |
| |
| Sparse highlighted it, and appears to be a pure bug (from vs to). |
| |
| ./arch/riscv/include/asm/uaccess.h:403:35: warning: incorrect type in argument 1 (different address spaces) |
| ./arch/riscv/include/asm/uaccess.h:403:39: warning: incorrect type in argument 2 (different address spaces) |
| ./arch/riscv/include/asm/uaccess.h:409:37: warning: incorrect type in argument 1 (different address spaces) |
| ./arch/riscv/include/asm/uaccess.h:409:41: warning: incorrect type in argument 2 (different address spaces) |
| |
| Signed-off-by: Olof Johansson <olof@lixom.net> |
| Cc: stable@vger.kernel.org |
| Signed-off-by: Palmer Dabbelt <palmer@sifive.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| arch/riscv/include/asm/uaccess.h | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| --- a/arch/riscv/include/asm/uaccess.h |
| +++ b/arch/riscv/include/asm/uaccess.h |
| @@ -400,13 +400,13 @@ extern unsigned long __must_check __asm_ |
| static inline unsigned long |
| raw_copy_from_user(void *to, const void __user *from, unsigned long n) |
| { |
| - return __asm_copy_to_user(to, from, n); |
| + return __asm_copy_from_user(to, from, n); |
| } |
| |
| static inline unsigned long |
| raw_copy_to_user(void __user *to, const void *from, unsigned long n) |
| { |
| - return __asm_copy_from_user(to, from, n); |
| + return __asm_copy_to_user(to, from, n); |
| } |
| |
| extern long strncpy_from_user(char *dest, const char __user *src, long count); |