| From foo@baz Thu Jan 12 21:36:14 CET 2017 |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| Date: Wed, 7 Dec 2016 14:22:03 +0300 |
| Subject: ser_gigaset: return -ENOMEM on error instead of success |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| |
| [ Upstream commit 93a97c50cbf1c007caf12db5cc23e0d5b9c8473c ] |
| |
| If we can't allocate the resources in gigaset_initdriver() then we |
| should return -ENOMEM instead of zero. |
| |
| Fixes: 2869b23e4b95 ("[PATCH] drivers/isdn/gigaset: new M101 driver (v2)") |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/isdn/gigaset/ser-gigaset.c | 4 +++- |
| 1 file changed, 3 insertions(+), 1 deletion(-) |
| |
| --- a/drivers/isdn/gigaset/ser-gigaset.c |
| +++ b/drivers/isdn/gigaset/ser-gigaset.c |
| @@ -762,8 +762,10 @@ static int __init ser_gigaset_init(void) |
| driver = gigaset_initdriver(GIGASET_MINOR, GIGASET_MINORS, |
| GIGASET_MODULENAME, GIGASET_DEVNAME, |
| &ops, THIS_MODULE); |
| - if (!driver) |
| + if (!driver) { |
| + rc = -ENOMEM; |
| goto error; |
| + } |
| |
| rc = tty_register_ldisc(N_GIGASET_M101, &gigaset_ldisc); |
| if (rc != 0) { |
