| From a991f8d3fe717f30d217e51c9146e054a4b99cfb Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 27 Feb 2019 13:37:26 +0300 |
| Subject: net: dev: Use unsigned integer as an argument to left-shift |
| |
| From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
| |
| [ Upstream commit f4d7b3e23d259c44f1f1c39645450680fcd935d6 ] |
| |
| 1 << 31 is Undefined Behaviour according to the C standard. |
| Use U type modifier to avoid theoretical overflow. |
| |
| Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| include/linux/netdevice.h | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h |
| index 2ecf0f32444e0..29ed5977ac041 100644 |
| --- a/include/linux/netdevice.h |
| +++ b/include/linux/netdevice.h |
| @@ -3565,7 +3565,7 @@ static inline u32 netif_msg_init(int debug_value, int default_msg_enable_bits) |
| if (debug_value == 0) /* no output */ |
| return 0; |
| /* set low N bits */ |
| - return (1 << debug_value) - 1; |
| + return (1U << debug_value) - 1; |
| } |
| |
| static inline void __netif_tx_lock(struct netdev_queue *txq, int cpu) |
| -- |
| 2.20.1 |
| |
