| From 67463d02de685909d56c04f424e1f2417b04a70d Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 26 Dec 2018 16:28:30 +0800 |
| Subject: net/wan/fsl_ucc_hdlc: Avoid double free in ucc_hdlc_probe() |
| |
| From: Wen Yang <wen.yang99@zte.com.cn> |
| |
| [ Upstream commit 40752b3eae29f8ca2378e978a02bd6dbeeb06d16 ] |
| |
| This patch fixes potential double frees if register_hdlc_device() fails. |
| |
| Signed-off-by: Wen Yang <wen.yang99@zte.com.cn> |
| Reviewed-by: Peng Hao <peng.hao2@zte.com.cn> |
| CC: Zhao Qiang <qiang.zhao@nxp.com> |
| CC: "David S. Miller" <davem@davemloft.net> |
| CC: netdev@vger.kernel.org |
| CC: linuxppc-dev@lists.ozlabs.org |
| CC: linux-kernel@vger.kernel.org |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/wan/fsl_ucc_hdlc.c | 1 - |
| 1 file changed, 1 deletion(-) |
| |
| diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c |
| index 7a62316c570d2..b2c1e872d5ed5 100644 |
| --- a/drivers/net/wan/fsl_ucc_hdlc.c |
| +++ b/drivers/net/wan/fsl_ucc_hdlc.c |
| @@ -1117,7 +1117,6 @@ static int ucc_hdlc_probe(struct platform_device *pdev) |
| if (register_hdlc_device(dev)) { |
| ret = -ENOBUFS; |
| pr_err("ucc_hdlc: unable to register hdlc device\n"); |
| - free_netdev(dev); |
| goto free_dev; |
| } |
| |
| -- |
| 2.20.1 |
| |
