| From c01c1db1dc632edafb0dff32d40daf4f9c1a4e19 Mon Sep 17 00:00:00 2001 |
| From: Xiaoke Wang <xkernel.wang@foxmail.com> |
| Date: Mon, 13 Dec 2021 15:39:31 +0800 |
| Subject: ALSA: jack: Check the return value of kstrdup() |
| |
| From: Xiaoke Wang <xkernel.wang@foxmail.com> |
| |
| commit c01c1db1dc632edafb0dff32d40daf4f9c1a4e19 upstream. |
| |
| kstrdup() can return NULL, it is better to check the return value of it. |
| |
| Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com> |
| Cc: <stable@vger.kernel.org> |
| Link: https://lore.kernel.org/r/tencent_094816F3522E0DC704056C789352EBBF0606@qq.com |
| Signed-off-by: Takashi Iwai <tiwai@suse.de> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| sound/core/jack.c | 4 ++++ |
| 1 file changed, 4 insertions(+) |
| |
| --- a/sound/core/jack.c |
| +++ b/sound/core/jack.c |
| @@ -234,6 +234,10 @@ int snd_jack_new(struct snd_card *card, |
| return -ENOMEM; |
| |
| jack->id = kstrdup(id, GFP_KERNEL); |
| + if (jack->id == NULL) { |
| + kfree(jack); |
| + return -ENOMEM; |
| + } |
| |
| /* don't creat input device for phantom jack */ |
| if (!phantom_jack) { |
