| From bc6476d6c1edcb9b97621b5131bd169aa81f27db Mon Sep 17 00:00:00 2001 |
| From: Johan Hovold <johan@kernel.org> |
| Date: Mon, 13 Nov 2017 12:12:55 +0100 |
| Subject: ASoC: da7218: fix fix child-node lookup |
| |
| From: Johan Hovold <johan@kernel.org> |
| |
| commit bc6476d6c1edcb9b97621b5131bd169aa81f27db upstream. |
| |
| Fix child-node lookup during probe, which ended up searching the whole |
| device tree depth-first starting at the parent rather than just matching |
| on its children. |
| |
| To make things worse, the parent codec node was also prematurely freed. |
| |
| Fixes: 4d50934abd22 ("ASoC: da7218: Add da7218 codec driver") |
| Signed-off-by: Johan Hovold <johan@kernel.org> |
| Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com> |
| Signed-off-by: Mark Brown <broonie@kernel.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| sound/soc/codecs/da7218.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/sound/soc/codecs/da7218.c |
| +++ b/sound/soc/codecs/da7218.c |
| @@ -2519,7 +2519,7 @@ static struct da7218_pdata *da7218_of_to |
| } |
| |
| if (da7218->dev_id == DA7218_DEV_ID) { |
| - hpldet_np = of_find_node_by_name(np, "da7218_hpldet"); |
| + hpldet_np = of_get_child_by_name(np, "da7218_hpldet"); |
| if (!hpldet_np) |
| return pdata; |
| |
