| From 770ef1614992538e703bcd99000204be8338aa9d Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 10 Nov 2020 09:24:36 +0800 |
| Subject: f2fs: avoid unneeded data copy in f2fs_ioc_move_range() |
| |
| From: Chao Yu <yuchao0@huawei.com> |
| |
| [ Upstream commit 3a1b9eaf727b4ab84ebf059e09c38fc6a53e5614 ] |
| |
| Fields in struct f2fs_move_range won't change in f2fs_ioc_move_range(), |
| let's avoid copying this structure's data to userspace. |
| |
| Signed-off-by: Chao Yu <yuchao0@huawei.com> |
| Reviewed-by: Eric Biggers <ebiggers@google.com> |
| Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| fs/f2fs/file.c | 6 ------ |
| 1 file changed, 6 deletions(-) |
| |
| diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c |
| index 9f857e5709b6..5c74b2997197 100644 |
| --- a/fs/f2fs/file.c |
| +++ b/fs/f2fs/file.c |
| @@ -2913,12 +2913,6 @@ static int __f2fs_ioc_move_range(struct file *filp, |
| range->pos_out, range->len); |
| |
| mnt_drop_write_file(filp); |
| - if (err) |
| - goto err_out; |
| - |
| - if (copy_to_user((struct f2fs_move_range __user *)arg, |
| - &range, sizeof(range))) |
| - err = -EFAULT; |
| err_out: |
| fdput(dst); |
| return err; |
| -- |
| 2.30.2 |
| |
