| From 3962e973cf73386fa7ec06b29098fb675dd17409 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 21 Jan 2021 03:49:07 -0800 |
| Subject: bus: qcom: Put child node before return |
| |
| From: Pan Bian <bianpan2016@163.com> |
| |
| [ Upstream commit ac6ad7c2a862d682bb584a4bc904d89fa7721af8 ] |
| |
| Put child node before return to fix potential reference count leak. |
| Generally, the reference count of child is incremented and decremented |
| automatically in the macro for_each_available_child_of_node() and should |
| be decremented manually if the loop is broken in loop body. |
| |
| Reviewed-by: Linus Walleij <linus.walleij@linaro.org> |
| Fixes: 335a12754808 ("bus: qcom: add EBI2 driver") |
| Signed-off-by: Pan Bian <bianpan2016@163.com> |
| Link: https://lore.kernel.org/r/20210121114907.109267-1-bianpan2016@163.com |
| Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/bus/qcom-ebi2.c | 4 +++- |
| 1 file changed, 3 insertions(+), 1 deletion(-) |
| |
| diff --git a/drivers/bus/qcom-ebi2.c b/drivers/bus/qcom-ebi2.c |
| index 03ddcf426887..0b8f53a688b8 100644 |
| --- a/drivers/bus/qcom-ebi2.c |
| +++ b/drivers/bus/qcom-ebi2.c |
| @@ -353,8 +353,10 @@ static int qcom_ebi2_probe(struct platform_device *pdev) |
| |
| /* Figure out the chipselect */ |
| ret = of_property_read_u32(child, "reg", &csindex); |
| - if (ret) |
| + if (ret) { |
| + of_node_put(child); |
| return ret; |
| + } |
| |
| if (csindex > 5) { |
| dev_err(dev, |
| -- |
| 2.30.2 |
| |
