| From a02706899a020015757a250d1da6b363e66e5fce Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 10 Feb 2021 07:45:27 +0000 |
| Subject: crypto: keembay-ocs-aes - Fix error return code in |
| kmb_ocs_aes_probe() |
| |
| From: Wei Yongjun <weiyongjun1@huawei.com> |
| |
| [ Upstream commit 2eee428d8212265af09d349b74746be03513382e ] |
| |
| Fix to return negative error code -ENOMEM from the error handling |
| case instead of 0, as done elsewhere in this function. |
| |
| Fixes: 885743324513 ("crypto: keembay - Add support for Keem Bay OCS AES/SM4") |
| Reported-by: Hulk Robot <hulkci@huawei.com> |
| Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> |
| Reviewed-by: Daniele Alessandrelli <daniele.alessandrelli@intel.com> |
| Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/crypto/keembay/keembay-ocs-aes-core.c | 4 +++- |
| 1 file changed, 3 insertions(+), 1 deletion(-) |
| |
| diff --git a/drivers/crypto/keembay/keembay-ocs-aes-core.c b/drivers/crypto/keembay/keembay-ocs-aes-core.c |
| index b6b25d994af3..2ef312866338 100644 |
| --- a/drivers/crypto/keembay/keembay-ocs-aes-core.c |
| +++ b/drivers/crypto/keembay/keembay-ocs-aes-core.c |
| @@ -1649,8 +1649,10 @@ static int kmb_ocs_aes_probe(struct platform_device *pdev) |
| |
| /* Initialize crypto engine */ |
| aes_dev->engine = crypto_engine_alloc_init(dev, true); |
| - if (!aes_dev->engine) |
| + if (!aes_dev->engine) { |
| + rc = -ENOMEM; |
| goto list_del; |
| + } |
| |
| rc = crypto_engine_start(aes_dev->engine); |
| if (rc) { |
| -- |
| 2.30.2 |
| |