| From 38d9fa9f8a082a25d4cfbaf37afa3b5de68135b2 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 1 Mar 2021 20:13:48 +0100 |
| Subject: Drivers: hv: vmbus: Drop error message when 'No request id available' |
| |
| From: Andrea Parri (Microsoft) <parri.andrea@gmail.com> |
| |
| [ Upstream commit 0c85c54bf7faeb80c6b76901ed77d93acef0207d ] |
| |
| Running out of request IDs on a channel essentially produces the same |
| effect as running out of space in the ring buffer, in that -EAGAIN is |
| returned. The error message in hv_ringbuffer_write() should either be |
| dropped (since we don't output a message when the ring buffer is full) |
| or be made conditional/debug-only. |
| |
| Suggested-by: Michael Kelley <mikelley@microsoft.com> |
| Signed-off-by: Andrea Parri (Microsoft) <parri.andrea@gmail.com> |
| Fixes: e8b7db38449ac ("Drivers: hv: vmbus: Add vmbus_requestor data structure for VMBus hardening") |
| Link: https://lore.kernel.org/r/20210301191348.196485-1-parri.andrea@gmail.com |
| Signed-off-by: Wei Liu <wei.liu@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/hv/ring_buffer.c | 1 - |
| 1 file changed, 1 deletion(-) |
| |
| diff --git a/drivers/hv/ring_buffer.c b/drivers/hv/ring_buffer.c |
| index 35833d4d1a1d..ecd82ebfd5bc 100644 |
| --- a/drivers/hv/ring_buffer.c |
| +++ b/drivers/hv/ring_buffer.c |
| @@ -313,7 +313,6 @@ int hv_ringbuffer_write(struct vmbus_channel *channel, |
| rqst_id = vmbus_next_request_id(&channel->requestor, requestid); |
| if (rqst_id == VMBUS_RQST_ERROR) { |
| spin_unlock_irqrestore(&outring_info->ring_lock, flags); |
| - pr_err("No request id available\n"); |
| return -EAGAIN; |
| } |
| } |
| -- |
| 2.30.2 |
| |