| From d34854f2e9f14917bff4d561ec4c5d9bc2670f8d Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 30 Mar 2021 12:31:52 +0300 |
| Subject: drm: xlnx: zynqmp: fix a memset in zynqmp_dp_train() |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| [ Upstream commit 5842ab76bbfadb37eaea91e53c1efe34ae504e4a ] |
| |
| The dp->train_set[] for this driver is only two characters, not four so |
| this memsets too much. Fortunately, this ends up corrupting a struct |
| hole and not anything important. |
| |
| Fixes: d76271d22694 ("drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort Subsystem") |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Reviewed-by: Michal Simek <michal.simek@xilinx.com> |
| Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> |
| Link: https://patchwork.freedesktop.org/patch/msgid/YGLwCBMotnrKZu6P@mwanda |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c |
| index 99158ee67d02..59d1fb017da0 100644 |
| --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c |
| +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c |
| @@ -866,7 +866,7 @@ static int zynqmp_dp_train(struct zynqmp_dp *dp) |
| return ret; |
| |
| zynqmp_dp_write(dp, ZYNQMP_DP_SCRAMBLING_DISABLE, 1); |
| - memset(dp->train_set, 0, 4); |
| + memset(dp->train_set, 0, sizeof(dp->train_set)); |
| ret = zynqmp_dp_link_train_cr(dp); |
| if (ret) |
| return ret; |
| -- |
| 2.30.2 |
| |
