| From 770b4e2142de3b467793223f2c2763d6d1835c49 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 8 Apr 2021 11:31:40 +0000 |
| Subject: IB/hfi1: Fix error return code in parse_platform_config() |
| |
| From: Wang Wensheng <wangwensheng4@huawei.com> |
| |
| [ Upstream commit 4c7d9c69adadfc31892c7e8e134deb3546552106 ] |
| |
| Fix to return a negative error code from the error handling case instead |
| of 0, as done elsewhere in this function. |
| |
| Fixes: 7724105686e7 ("IB/hfi1: add driver files") |
| Link: https://lore.kernel.org/r/20210408113140.103032-1-wangwensheng4@huawei.com |
| Reported-by: Hulk Robot <hulkci@huawei.com> |
| Signed-off-by: Wang Wensheng <wangwensheng4@huawei.com> |
| Signed-off-by: Jason Gunthorpe <jgg@nvidia.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/infiniband/hw/hfi1/firmware.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/drivers/infiniband/hw/hfi1/firmware.c b/drivers/infiniband/hw/hfi1/firmware.c |
| index 0e83d4b61e46..2cf102b5abd4 100644 |
| --- a/drivers/infiniband/hw/hfi1/firmware.c |
| +++ b/drivers/infiniband/hw/hfi1/firmware.c |
| @@ -1916,6 +1916,7 @@ int parse_platform_config(struct hfi1_devdata *dd) |
| dd_dev_err(dd, "%s: Failed CRC check at offset %ld\n", |
| __func__, (ptr - |
| (u32 *)dd->platform_config.data)); |
| + ret = -EINVAL; |
| goto bail; |
| } |
| /* Jump the CRC DWORD */ |
| -- |
| 2.30.2 |
| |