| From de0adbda32457666bdda52293169b44917a350c4 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 26 Feb 2021 10:17:37 +0800 |
| Subject: regmap: set debugfs_name to NULL after it is freed |
| |
| From: Meng Li <Meng.Li@windriver.com> |
| |
| [ Upstream commit e41a962f82e7afb5b1ee644f48ad0b3aee656268 ] |
| |
| There is a upstream commit cffa4b2122f5("regmap:debugfs: |
| Fix a memory leak when calling regmap_attach_dev") that |
| adds a if condition when create name for debugfs_name. |
| With below function invoking logical, debugfs_name is |
| freed in regmap_debugfs_exit(), but it is not created again |
| because of the if condition introduced by above commit. |
| regmap_reinit_cache() |
| regmap_debugfs_exit() |
| ... |
| regmap_debugfs_init() |
| So, set debugfs_name to NULL after it is freed. |
| |
| Fixes: cffa4b2122f5 ("regmap: debugfs: Fix a memory leak when calling regmap_attach_dev") |
| Signed-off-by: Meng Li <Meng.Li@windriver.com> |
| Link: https://lore.kernel.org/r/20210226021737.7690-1-Meng.Li@windriver.com |
| Signed-off-by: Mark Brown <broonie@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/base/regmap/regmap-debugfs.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/drivers/base/regmap/regmap-debugfs.c b/drivers/base/regmap/regmap-debugfs.c |
| index ff2ee87987c7..211a335a608d 100644 |
| --- a/drivers/base/regmap/regmap-debugfs.c |
| +++ b/drivers/base/regmap/regmap-debugfs.c |
| @@ -660,6 +660,7 @@ void regmap_debugfs_exit(struct regmap *map) |
| regmap_debugfs_free_dump_cache(map); |
| mutex_unlock(&map->cache_lock); |
| kfree(map->debugfs_name); |
| + map->debugfs_name = NULL; |
| } else { |
| struct regmap_debugfs_node *node, *tmp; |
| |
| -- |
| 2.30.2 |
| |