| From 2b35ceba3677806b8a7818dfd5386779be9e0b91 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 15 Mar 2021 12:23:37 +0300 |
| Subject: rtw88: Fix an error code in rtw_debugfs_set_rsvd_page() |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| [ Upstream commit c9eaee0c2ec6b1002044fb698cdfb5d9ef4ed28c ] |
| |
| The sscanf() function returns the number of matches (0 or 1 in this |
| case). It doesn't return error codes. We should return -EINVAL if the |
| string is invalid |
| |
| Fixes: c376c1fc87b7 ("rtw88: add h2c command in debugfs") |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Signed-off-by: Kalle Valo <kvalo@codeaurora.org> |
| Link: https://lore.kernel.org/r/YE8nmatMDBDDWkjq@mwanda |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/wireless/realtek/rtw88/debug.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/net/wireless/realtek/rtw88/debug.c b/drivers/net/wireless/realtek/rtw88/debug.c |
| index 19fc2d8bf3e9..f872fcd15699 100644 |
| --- a/drivers/net/wireless/realtek/rtw88/debug.c |
| +++ b/drivers/net/wireless/realtek/rtw88/debug.c |
| @@ -270,7 +270,7 @@ static ssize_t rtw_debugfs_set_rsvd_page(struct file *filp, |
| |
| if (num != 2) { |
| rtw_warn(rtwdev, "invalid arguments\n"); |
| - return num; |
| + return -EINVAL; |
| } |
| |
| debugfs_priv->rsvd_page.page_offset = offset; |
| -- |
| 2.30.2 |
| |
