| From 4de659a61a0bd641d5a35174bec942dfd5cb193f Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 7 Apr 2021 16:03:08 +0100 |
| Subject: staging: rtl8192u: Fix potential infinite loop |
| |
| From: Colin Ian King <colin.king@canonical.com> |
| |
| [ Upstream commit f9b9263a25dc3d2eaaa829e207434db6951ca7bc ] |
| |
| The for-loop iterates with a u8 loop counter i and compares this |
| with the loop upper limit of riv->ieee80211->LinkDetectInfo.SlotNum |
| that is a u16 type. There is a potential infinite loop if SlotNum |
| is larger than the u8 loop counter. Fix this by making the loop |
| counter the same type as SlotNum. |
| |
| Addresses-Coverity: ("Infinite loop") |
| Fixes: 8fc8598e61f6 ("Staging: Added Realtek rtl8192u driver to staging") |
| Signed-off-by: Colin Ian King <colin.king@canonical.com> |
| Link: https://lore.kernel.org/r/20210407150308.496623-1-colin.king@canonical.com |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/staging/rtl8192u/r8192U_core.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c |
| index 93676af98629..60935c739476 100644 |
| --- a/drivers/staging/rtl8192u/r8192U_core.c |
| +++ b/drivers/staging/rtl8192u/r8192U_core.c |
| @@ -3208,7 +3208,7 @@ static void rtl819x_update_rxcounts(struct r8192_priv *priv, u32 *TotalRxBcnNum, |
| u32 *TotalRxDataNum) |
| { |
| u16 SlotIndex; |
| - u8 i; |
| + u16 i; |
| |
| *TotalRxBcnNum = 0; |
| *TotalRxDataNum = 0; |
| -- |
| 2.30.2 |
| |