| From 0d9bd9d03ef432bd5b7d73c81786a87d45bbee4f Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 15 Dec 2021 20:30:32 +0300 |
| Subject: dsa: mv88e6xxx: fix debug print for SPEED_UNFORCED |
| |
| From: Andrey Eremeev <Axtone4all@yandex.ru> |
| |
| [ Upstream commit e08cdf63049b711099efff0811273449083bb958 ] |
| |
| Debug print uses invalid check to detect if speed is unforced: |
| (speed != SPEED_UNFORCED) should be used instead of (!speed). |
| |
| Found by Linux Verification Center (linuxtesting.org) with SVACE. |
| |
| Signed-off-by: Andrey Eremeev <Axtone4all@yandex.ru> |
| Fixes: 96a2b40c7bd3 ("net: dsa: mv88e6xxx: add port's MAC speed setter") |
| Reviewed-by: Andrew Lunn <andrew@lunn.ch> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/dsa/mv88e6xxx/port.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| diff --git a/drivers/net/dsa/mv88e6xxx/port.c b/drivers/net/dsa/mv88e6xxx/port.c |
| index d9817b20ea641..ab41619a809b3 100644 |
| --- a/drivers/net/dsa/mv88e6xxx/port.c |
| +++ b/drivers/net/dsa/mv88e6xxx/port.c |
| @@ -283,7 +283,7 @@ static int mv88e6xxx_port_set_speed_duplex(struct mv88e6xxx_chip *chip, |
| if (err) |
| return err; |
| |
| - if (speed) |
| + if (speed != SPEED_UNFORCED) |
| dev_dbg(chip->dev, "p%d: Speed set to %d Mbps\n", port, speed); |
| else |
| dev_dbg(chip->dev, "p%d: Speed unforced\n", port); |
| @@ -516,7 +516,7 @@ int mv88e6393x_port_set_speed_duplex(struct mv88e6xxx_chip *chip, int port, |
| if (err) |
| return err; |
| |
| - if (speed) |
| + if (speed != SPEED_UNFORCED) |
| dev_dbg(chip->dev, "p%d: Speed set to %d Mbps\n", port, speed); |
| else |
| dev_dbg(chip->dev, "p%d: Speed unforced\n", port); |
| -- |
| 2.33.0 |
| |
