| From 8b8c28d0f30ade6cb70e7f7d469775fa6224b094 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 20 Jan 2020 20:58:43 +0800 |
| Subject: dmaengine: fsl-qdma: fix duplicated argument to && |
| |
| From: Chen Zhou <chenzhou10@huawei.com> |
| |
| [ Upstream commit 4b048178854da11656596d36a107577d66fd1e08 ] |
| |
| There is duplicated argument to && in function fsl_qdma_free_chan_resources, |
| which looks like a typo, pointer fsl_queue->desc_pool also needs NULL check, |
| fix it. |
| Detected with coccinelle. |
| |
| Fixes: b092529e0aa0 ("dmaengine: fsl-qdma: Add qDMA controller driver for Layerscape SoCs") |
| Signed-off-by: Chen Zhou <chenzhou10@huawei.com> |
| Reviewed-by: Peng Ma <peng.ma@nxp.com> |
| Tested-by: Peng Ma <peng.ma@nxp.com> |
| Link: https://lore.kernel.org/r/20200120125843.34398-1-chenzhou10@huawei.com |
| Signed-off-by: Vinod Koul <vkoul@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/dma/fsl-qdma.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/dma/fsl-qdma.c b/drivers/dma/fsl-qdma.c |
| index 89792083d62c5..95cc0256b3878 100644 |
| --- a/drivers/dma/fsl-qdma.c |
| +++ b/drivers/dma/fsl-qdma.c |
| @@ -304,7 +304,7 @@ static void fsl_qdma_free_chan_resources(struct dma_chan *chan) |
| |
| vchan_dma_desc_free_list(&fsl_chan->vchan, &head); |
| |
| - if (!fsl_queue->comp_pool && !fsl_queue->comp_pool) |
| + if (!fsl_queue->comp_pool && !fsl_queue->desc_pool) |
| return; |
| |
| list_for_each_entry_safe(comp_temp, _comp_temp, |
| -- |
| 2.20.1 |
| |
