| From 9d24972683132dceaccfcdb9870456330da077d2 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sat, 28 Dec 2019 19:54:55 +0800 |
| Subject: kernel/module: Fix memleak in module_add_modinfo_attrs() |
| |
| From: YueHaibing <yuehaibing@huawei.com> |
| |
| [ Upstream commit f6d061d617124abbd55396a3bc37b9bf7d33233c ] |
| |
| In module_add_modinfo_attrs() if sysfs_create_file() fails |
| on the first iteration of the loop (so i = 0), we forget to |
| free the modinfo_attrs. |
| |
| Fixes: bc6f2a757d52 ("kernel/module: Fix mem leak in module_add_modinfo_attrs") |
| Reviewed-by: Miroslav Benes <mbenes@suse.cz> |
| Signed-off-by: YueHaibing <yuehaibing@huawei.com> |
| Signed-off-by: Jessica Yu <jeyu@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| kernel/module.c | 2 ++ |
| 1 file changed, 2 insertions(+) |
| |
| diff --git a/kernel/module.c b/kernel/module.c |
| index cb09a5f37a5fc..9fb8fa22e16b3 100644 |
| --- a/kernel/module.c |
| +++ b/kernel/module.c |
| @@ -1781,6 +1781,8 @@ static int module_add_modinfo_attrs(struct module *mod) |
| error_out: |
| if (i > 0) |
| module_remove_modinfo_attrs(mod, --i); |
| + else |
| + kfree(mod->modinfo_attrs); |
| return error; |
| } |
| |
| -- |
| 2.20.1 |
| |
