| From a5e42eab8b5025691445af86c90eb09a2ef21535 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 19 Aug 2020 15:56:32 +0800 |
| Subject: RDMA/rxe: Fix memleak in rxe_mem_init_user |
| |
| From: Dinghao Liu <dinghao.liu@zju.edu.cn> |
| |
| [ Upstream commit e3ddd6067ee62f6e76ebcf61ff08b2c729ae412b ] |
| |
| When page_address() fails, umem should be freed just like when |
| rxe_mem_alloc() fails. |
| |
| Fixes: 8700e3e7c485 ("Soft RoCE driver") |
| Link: https://lore.kernel.org/r/20200819075632.22285-1-dinghao.liu@zju.edu.cn |
| Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> |
| Signed-off-by: Jason Gunthorpe <jgg@nvidia.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/infiniband/sw/rxe/rxe_mr.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/drivers/infiniband/sw/rxe/rxe_mr.c b/drivers/infiniband/sw/rxe/rxe_mr.c |
| index ea6a819b71675..ffbc50341a55a 100644 |
| --- a/drivers/infiniband/sw/rxe/rxe_mr.c |
| +++ b/drivers/infiniband/sw/rxe/rxe_mr.c |
| @@ -207,6 +207,7 @@ int rxe_mem_init_user(struct rxe_pd *pd, u64 start, |
| vaddr = page_address(sg_page_iter_page(&sg_iter)); |
| if (!vaddr) { |
| pr_warn("null vaddr\n"); |
| + ib_umem_release(umem); |
| err = -ENOMEM; |
| goto err1; |
| } |
| -- |
| 2.25.1 |
| |