| From 0350cb078f5035716ebdad4ad4709d02fe466a8a Mon Sep 17 00:00:00 2001 |
| From: Dan Carpenter <error27@gmail.com> |
| Date: Thu, 22 Apr 2010 11:39:29 +0200 |
| Subject: ocfs2: potential ERR_PTR dereference on error paths |
| |
| From: Dan Carpenter <error27@gmail.com> |
| |
| commit 0350cb078f5035716ebdad4ad4709d02fe466a8a upstream. |
| |
| If "handle" is non null at the end of the function then we assume it's a |
| valid pointer and pass it to ocfs2_commit_trans(); |
| |
| Signed-off-by: Dan Carpenter <error27@gmail.com> |
| Signed-off-by: Joel Becker <joel.becker@oracle.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> |
| |
| --- |
| fs/ocfs2/inode.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| --- a/fs/ocfs2/inode.c |
| +++ b/fs/ocfs2/inode.c |
| @@ -559,6 +559,7 @@ static int ocfs2_truncate_for_delete(str |
| handle = ocfs2_start_trans(osb, OCFS2_INODE_UPDATE_CREDITS); |
| if (IS_ERR(handle)) { |
| status = PTR_ERR(handle); |
| + handle = NULL; |
| mlog_errno(status); |
| goto out; |
| } |