| From 0250ececdf6813457c98719e2d33b3684881fde0 Mon Sep 17 00:00:00 2001 |
| From: Hans de Goede <hdegoede@redhat.com> |
| Date: Thu, 22 Apr 2010 19:52:16 +0200 |
| Subject: p54pci: fix bugs in p54p_check_tx_ring |
| |
| From: Hans de Goede <hdegoede@redhat.com> |
| |
| commit 0250ececdf6813457c98719e2d33b3684881fde0 upstream. |
| |
| Hans de Goede identified a bug in p54p_check_tx_ring: |
| |
| there are two ring indices. 1 => tx data and 3 => tx management. |
| But the old code had a constant "1" and this resulted in spurious |
| dma unmapping failures. |
| |
| Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=583623 |
| Bug-Identified-by: Hans de Goede <hdegoede@redhat.com> |
| Signed-off-by: Christian Lamparter <chunkeey@googlemail.com> |
| Signed-off-by: John W. Linville <linville@tuxdriver.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> |
| |
| --- |
| drivers/net/wireless/p54/p54pci.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/net/wireless/p54/p54pci.c |
| +++ b/drivers/net/wireless/p54/p54pci.c |
| @@ -245,7 +245,7 @@ static void p54p_check_tx_ring(struct ie |
| u32 idx, i; |
| |
| i = (*index) % ring_limit; |
| - (*index) = idx = le32_to_cpu(ring_control->device_idx[1]); |
| + (*index) = idx = le32_to_cpu(ring_control->device_idx[ring_index]); |
| idx %= ring_limit; |
| |
| while (i != idx) { |
