| From fa7fe7af146a7b613e36a311eefbbfb5555325d1 Mon Sep 17 00:00:00 2001 |
| From: Dan Carpenter <error27@gmail.com> |
| Date: Thu, 22 Apr 2010 12:00:52 +0200 |
| Subject: USB: fix testing the wrong variable in fs_create_by_name() |
| |
| From: Dan Carpenter <error27@gmail.com> |
| |
| commit fa7fe7af146a7b613e36a311eefbbfb5555325d1 upstream. |
| |
| There is a typo here. We should be testing "*dentry" which was just |
| assigned instead of "dentry". This could result in dereferencing an |
| ERR_PTR inside either usbfs_mkdir() or usbfs_create(). |
| |
| Signed-off-by: Dan Carpenter <error27@gmail.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> |
| |
| --- |
| drivers/usb/core/inode.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| --- a/drivers/usb/core/inode.c |
| +++ b/drivers/usb/core/inode.c |
| @@ -515,13 +515,13 @@ static int fs_create_by_name (const char |
| *dentry = NULL; |
| mutex_lock(&parent->d_inode->i_mutex); |
| *dentry = lookup_one_len(name, parent, strlen(name)); |
| - if (!IS_ERR(dentry)) { |
| + if (!IS_ERR(*dentry)) { |
| if ((mode & S_IFMT) == S_IFDIR) |
| error = usbfs_mkdir (parent->d_inode, *dentry, mode); |
| else |
| error = usbfs_create (parent->d_inode, *dentry, mode); |
| } else |
| - error = PTR_ERR(dentry); |
| + error = PTR_ERR(*dentry); |
| mutex_unlock(&parent->d_inode->i_mutex); |
| |
| return error; |
